mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 56215: Reused previous task status to generate a new one in default executor.
Date Mon, 20 Mar 2017 11:55:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56215/
-----------------------------------------------------------

(Updated March 20, 2017, 11:55 a.m.)


Review request for mesos, Gastón Kleiman and Vinod Kone.


Bugs: MESOS-7249
    https://issues.apache.org/jira/browse/MESOS-7249


Repository: mesos


Description
-------

Sometimes when a new task status update is generated in the executor,
we have to make sure specific data is duplicated from the previous
task status to, e.g., avoid shadowing of these data during
reconciliation. For instance, consider a check status being sent;
in this status update we must include the latest known health
information.

This patch also refactors `update()` routine into two separate calls:
`createTaskStatus()` which is responsible for creating a task status
from scratch and `forward()`, which is responsible for forwarding task
status updates to the agent.


Diffs (updated)
-----

  src/launcher/default_executor.cpp cbd4f7ecd042e7fa603bd69774d95472df2c896d 


Diff: https://reviews.apache.org/r/56215/diff/7/

Changes: https://reviews.apache.org/r/56215/diff/6-7/


Testing
-------

See https://reviews.apache.org/r/56218/


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message