mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 57534: Added and implemented RegisterAgent ACL.
Date Mon, 20 Mar 2017 04:06:55 GMT


> On March 17, 2017, 2:32 p.m., Greg Mann wrote:
> > src/tests/authorization_tests.cpp
> > Lines 4270 (patched)
> > <https://reviews.apache.org/r/57534/diff/3/?file=1665068#file1665068line4270>
> >
> >     Could you also add a test case with the ANY subject?

This test already covers the subject being ANY in the ACL:

```
  {
    // Nobody else can register as an agent.
    mesos::ACL::RegisterAgent* acl = acls.add_register_agents();
    acl->mutable_principals()->set_type(mesos::ACL::Entity::ANY);
    acl->mutable_agent()->set_type(mesos::ACL::Entity::NONE);
  }
```

I assume you meant subject being ANY in the request. Sadly, it appears that this has never
worked (see MESOS-7244), we should fix it but I don't want to get entangled with it in this
patch. (No other tests were written to uncovere this)


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57534/#review169323
-----------------------------------------------------------


On March 14, 2017, 5:40 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57534/
> -----------------------------------------------------------
> 
> (Updated March 14, 2017, 5:40 p.m.)
> 
> 
> Review request for mesos, Adam B, Anindya Sinha, Alexander Rojas, and Greg Mann.
> 
> 
> Bugs: MESOS-7097
>     https://issues.apache.org/jira/browse/MESOS-7097
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added and implemented RegisterAgent ACL.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/acls.proto e75e1879435f1c2bce47a86e9feebf9d051e969b 
>   include/mesos/authorizer/authorizer.proto 736f76d552956f2351ffd40fc51d088dff83f8c8

>   src/authorizer/local/authorizer.cpp be8037299601427e5d5e79f58f77eea3f89579d0 
>   src/tests/authorization_tests.cpp cd15add7d7b01c2b316ac946e017a4d0b502237f 
> 
> 
> Diff: https://reviews.apache.org/r/57534/diff/3/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message