mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 57739: Completed frameworks should be tracked based on source.
Date Sun, 19 Mar 2017 06:44:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57739/#review169368
-----------------------------------------------------------



Can we add a test?


src/master/master.hpp
Lines 802-804 (patched)
<https://reviews.apache.org/r/57739/#comment241731>

    This method can possbily be called with a combination of these args but in reality we
only need one of the three to be set. The abstraction suggested below which allows you to
overload the method with each type is better.



src/master/master.hpp
Lines 1763-1764 (original), 1770-1772 (patched)
<https://reviews.apache.org/r/57739/#comment241729>

    I think it's cleaner if we can model it after `slaves.registered`:
    
    ```
    struct Frameworks
    {
      ...
      
      struct
      {
        bool contains(const FrameworkID& slaveId) const;
        bool contains(const process::UPID& slaveId) const;
        bool contains(const HttpConnection& slaveId) const;
        void put(Framework*);
        const_iterator begin() const;
        const_iterator end()   const;
        ...
      private:
        BoundedHashMap<FrameworkID, std::shared_ptr<Framework> frameworkIds;
        BoundedHashMap<process::UPID, std::shared_ptr<Framework> pids;
        BoundedHashMap<UUID, std::shared_ptr<Framework>> streamIds;
      } completed;
    } frameworks;
    ```



src/master/master.cpp
Lines 2654 (patched)
<https://reviews.apache.org/r/57739/#comment241730>

    Keep the error message consistent: "Framework has been removed"


- Jiang Yan Xu


On March 17, 2017, 4:36 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57739/
> -----------------------------------------------------------
> 
> (Updated March 17, 2017, 4:36 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7181
>     https://issues.apache.org/jira/browse/MESOS-7181
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In addition to tracking completed frameworks based on framework id, we
> also keep track of the source (`streamId` for http connections, or
> `upid` for scheduler driver). This information is used to ensure that
> retransmitted SUBSCRIBEs from the same source are dropped irrespective
> of those frameworks are connected or not.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp d92c8adef79d997f255cf26ebd10ab0e87da8413 
>   src/master/master.cpp 43e9d26167c1f405329ea05224c22e7b8c65315f 
> 
> 
> Diff: https://reviews.apache.org/r/57739/diff/1/
> 
> 
> Testing
> -------
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message