mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 55895: Add zero byte disk resource support to XFS.
Date Fri, 17 Mar 2017 21:57:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55895/
-----------------------------------------------------------

(Updated March 17, 2017, 9:57 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Bugs: MESOS-5393
    https://issues.apache.org/jira/browse/MESOS-5393


Repository: mesos


Description
-------

Support containers with zero byte disk resources in the XFS
isolator. This works by setting the quota to the minimum amount
(1 block), since the quota system defines 0 as unlimited.


Diffs (updated)
-----

  src/slave/containerizer/mesos/isolators/xfs/disk.cpp 40f1049358ad99d3f213289e36def81c580f07f3

  src/slave/containerizer/mesos/isolators/xfs/utils.hpp eddd4c37fb42339ca21ecb392dea47acf6b277bb

  src/slave/containerizer/mesos/isolators/xfs/utils.cpp 8018ad348d26bd962357543a5fb9f6cb43ff13b1

  src/tests/containerizer/xfs_quota_tests.cpp 7beb60b059910a0d4451b1ace895a35dc974a043 


Diff: https://reviews.apache.org/r/55895/diff/2/

Changes: https://reviews.apache.org/r/55895/diff/1-2/


Testing
-------

sudo make check (Fedora 25)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message