mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 57472: Removing deprecated ACLs `SetQuota` and `RemoveQuota`.
Date Fri, 17 Mar 2017 11:08:13 GMT


> On March 13, 2017, 10:23 p.m., Alexander Rukletsov wrote:
> > docs/upgrades.md
> > Lines 261-263 (patched)
> > <https://reviews.apache.org/r/57472/diff/3/?file=1661191#file1661191line261>
> >
> >     Let's say how they should update the cluster.
> >     
> >     ```
> >     * When upgrading a Mesos cluster that uses the `set_quotas` or `remove_quotas`
ACLs, the operator should first upgrade the Mesos binaries. At this point, the deprecated
ACLs will still be enforced. After the upgrade has been verified, the operator should replace
deprecated values for `set_quotas` and `remove_quotas` with equivalent values for `update_quotas`;
> >     ```

Don't think we do that in the document. I can make a summary of what you said. However, don't
you need to first upgrade the ACLs (we are deleting support from them) and then the binaries?


> On March 13, 2017, 10:23 p.m., Alexander Rukletsov wrote:
> > include/mesos/authorizer/acls.proto
> > Lines 406-409 (original)
> > <https://reviews.apache.org/r/57472/diff/3/?file=1661192#file1661192line406>
> >
> >     Do we usually keep a comment saying that tags `9` and `10` are not allowed to
be used any more?

I don't think we do, but it does sound important.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57472/#review168830
-----------------------------------------------------------


On March 13, 2017, 1:48 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57472/
> -----------------------------------------------------------
> 
> (Updated March 13, 2017, 1:48 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The ACLs `SetQuota` and `RemoveQuota` where marked for deprecation
> more than six months ago, where they were replaced for the more
> convenient `UpdateQuota` ACL. The deprecation cycle for these actions
> is finally due while at the same time removing will make easier to
> implement the hierarchical role feature in a generic way.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 0a4e1dd52f9197151c5ef4318579ffa4e9bcf0ee 
>   docs/upgrades.md e7f95aadeee330b3a9dbafc0f716c13df1bc8252 
>   include/mesos/authorizer/acls.proto 8389917d12f9a9a3c9b4281f48e23ade14c20528 
>   src/authorizer/local/authorizer.cpp 2227b241eab1606815fa6464e3d6b1345624fd22 
>   src/master/master.hpp d92c8adef79d997f255cf26ebd10ab0e87da8413 
>   src/master/quota_handler.cpp 36ea1acca47014b2fb7a3b597b857c8ec9e2ab67 
>   src/tests/authorization_tests.cpp 42edecc794b71a00ca32d26ae9b74e9f3ef97510 
>   src/tests/master_quota_tests.cpp e418f22ea1773f4356ced44b8d57a80e826c8837 
> 
> 
> Diff: https://reviews.apache.org/r/57472/diff/3/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message