mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 57713: Added `virtualenv` as a dependency in `getting-started.md`.
Date Fri, 17 Mar 2017 08:37:24 GMT


> On March 17, 2017, 1:46 a.m., Joseph Wu wrote:
> > docs/windows.md
> > Lines 26 (patched)
> > <https://reviews.apache.org/r/57713/diff/2/?file=1666564#file1666564line26>
> >
> >     I'd prefer a link to the download page, rather than to some random blog: https://www.python.org/downloads/windows/
> >     
> >     You can add `pip install virtualenv` afterwards.  I don't think the `virtualenvwrapper-win`
is necessary either.

+1
Also mention that Python 2.x needs to be installed, not Python 3.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57713/#review169237
-----------------------------------------------------------


On March 17, 2017, 1:39 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57713/
> -----------------------------------------------------------
> 
> (Updated March 17, 2017, 1:39 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joseph Wu, Michael Park, and Jan Schlicht.
> 
> 
> Bugs: MESOS-7255
>     https://issues.apache.org/jira/browse/MESOS-7255
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `virtualenv` as a dependency in `getting-started.md`.
> 
> 
> Diffs
> -----
> 
>   docs/getting-started.md 268eb29551c6cd9cbea50b2c971f97ca74bab18f 
>   docs/windows.md 38275f30638a0197b41f55b454b7a722bea24b3e 
> 
> 
> Diff: https://reviews.apache.org/r/57713/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message