mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 53264: Added test for CNI port-mapper plugin.
Date Thu, 16 Mar 2017 22:42:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53264/#review169217
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/cni_isolator_tests.cpp
Lines 54 (patched)
<https://reviews.apache.org/r/53264/#comment241550>

    `__MESOS_TEST_PORT_MAPPER__`



src/tests/containerizer/cni_isolator_tests.cpp
Lines 133-136 (patched)
<https://reviews.apache.org/r/53264/#comment241551>

    No need for this?



src/tests/containerizer/cni_isolator_tests.cpp
Lines 1016 (patched)
<https://reviews.apache.org/r/53264/#comment241553>

    I think getLauncherDir should also work. No need the `.libs` suffix?



src/tests/containerizer/cni_isolator_tests.cpp
Lines 1053-1063 (patched)
<https://reviews.apache.org/r/53264/#comment241558>

    I think you can leverage `std::random_shuffle` here. I think it supports any iterator.


- Jie Yu


On March 16, 2017, 5:24 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53264/
> -----------------------------------------------------------
> 
> (Updated March 16, 2017, 5:24 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-6022
>     https://issues.apache.org/jira/browse/MESOS-6022
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test for CNI port-mapper plugin.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cni_isolator_tests.cpp cb893d3ef005a9cc60c40768fa669b27c4863020

> 
> 
> Diff: https://reviews.apache.org/r/53264/diff/7/
> 
> 
> Testing
> -------
> 
> sudo ./bin/mesos-tests.sh --gtest_filter=CniIsolator*.*
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message