mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 57664: Added the '--executor_secret_key' agent flag.
Date Thu, 16 Mar 2017 18:59:40 GMT


> On March 16, 2017, 1:06 p.m., Vinod Kone wrote:
> > src/slave/flags.cpp
> > Lines 348 (patched)
> > <https://reviews.apache.org/r/57664/diff/1/?file=1665762#file1665762line348>
> >
> >     s/default//
> >     
> >     we will generate secrets using this key for command, docker and custom executors
as well right?

I was rather intending to indicate that they are "default secrets", instead of referring to
the "default executor". But it's a bit confusing, I'll just remove "default" altogether.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57664/#review169137
-----------------------------------------------------------


On March 16, 2017, 6:59 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57664/
> -----------------------------------------------------------
> 
> (Updated March 16, 2017, 6:59 p.m.)
> 
> 
> Review request for mesos, Jan Schlicht and Vinod Kone.
> 
> 
> Bugs: MESOS-7011
>     https://issues.apache.org/jira/browse/MESOS-7011
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a new agent flag, `--executor_secret_key` to allow the
> specification of a secret key to be used when generating and
> authenticating default executor tokens.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 9f747406e91840335f97c0166ca75373e47d319b 
>   src/slave/flags.hpp 2c4bd6ae628a272a4c6c2f02670baef011df4505 
>   src/slave/flags.cpp 4637ca62b257921c1e1f7019864d968f07fca8a1 
> 
> 
> Diff: https://reviews.apache.org/r/57664/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message