mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 57628: Added a utility function to get back non-loopback address on the host.
Date Thu, 16 Mar 2017 18:38:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57628/#review169187
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/utils.hpp
Line 83 (original), 84 (patched)
<https://reviews.apache.org/r/57628/#comment241522>

    2 lines apart. Can you fix this style issue in this file in a separate patch?



src/tests/utils.cpp
Line 185 (original), 186 (patched)
<https://reviews.apache.org/r/57628/#comment241523>

    2 lines apart.



src/tests/utils.cpp
Lines 187 (patched)
<https://reviews.apache.org/r/57628/#comment241528>

    Let's follow up with a patch to use this funciton in the CNI isolator test and kill the
same method in the test fixture.



src/tests/utils.cpp
Lines 195 (patched)
<https://reviews.apache.org/r/57628/#comment241527>

    No need to declare this variable outside the for loop?


- Jie Yu


On March 14, 2017, 11:06 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57628/
> -----------------------------------------------------------
> 
> (Updated March 14, 2017, 11:06 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6022
>     https://issues.apache.org/jira/browse/MESOS-6022
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a utility function to get back non-loopback address on the host.
> 
> 
> Diffs
> -----
> 
>   src/tests/utils.hpp cdbbc1c611bbcf2d6548f6b65fb08c6a4831b7a8 
>   src/tests/utils.cpp 0a9e5a867a46795f01fcf7030f50581b5ef1341f 
> 
> 
> Diff: https://reviews.apache.org/r/57628/diff/1/
> 
> 
> Testing
> -------
> 
> sudo ./bin/mesos-tests.sh --gtest_filter=CniIsolator*.*
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message