mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 57615: Added support for auth tokens to the V1 executor library.
Date Thu, 16 Mar 2017 13:41:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57615/#review169149
-----------------------------------------------------------




src/executor/executor.cpp
Lines 227 (patched)
<https://reviews.apache.org/r/57615/#comment241479>

    update the name per previous review.



src/executor/executor.cpp
Lines 319 (patched)
<https://reviews.apache.org/r/57615/#comment241480>

    this is token not the authorization header right? if yes we need to add the "Bearer: "
prefix to the token here?


- Vinod Kone


On March 15, 2017, 10:09 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57615/
> -----------------------------------------------------------
> 
> (Updated March 15, 2017, 10:09 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Jan Schlicht, and Vinod Kone.
> 
> 
> Bugs: MESOS-6304
>     https://issues.apache.org/jira/browse/MESOS-6304
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds support for authentication tokens to the
> V1 default executor library. The tokens are loaded from a
> pre-determined environment variable, if present.
> 
> 
> Diffs
> -----
> 
>   src/executor/executor.cpp 35378ec4b55ce0427e95f6b868baa6233c9068cd 
> 
> 
> Diff: https://reviews.apache.org/r/57615/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> Once MESOS-6999 is resolved, additional tests must be implemented to verify that executor
authentication is performed correctly.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message