mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 56214: Hashed unacknowledged updates by UUID string in default executor.
Date Thu, 16 Mar 2017 11:18:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56214/
-----------------------------------------------------------

(Updated March 16, 2017, 11:18 a.m.)


Review request for mesos, Gastón Kleiman and Vinod Kone.


Repository: mesos


Description
-------

Update acknowledgements contain UUID as string, a conversion is
anyway necessary. In the future we may not have access to the
original UUID, while string representation is always available in
the protobuf message itself. Hence it seems reasonable to hash
updates by string instead of UUID.


Diffs
-----

  src/launcher/default_executor.cpp e63cf153831088851863d0956455a024e9bc172a 


Diff: https://reviews.apache.org/r/56214/diff/3/


Testing
-------

See https://reviews.apache.org/r/56218/


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message