mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 57427: Added authorization for PULL_CONTAINER_IMAGE agent API call.
Date Wed, 15 Mar 2017 23:05:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57427/#review169074
-----------------------------------------------------------



Patch looks great!

Reviews applied: [57425, 57426, 57427]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On March 15, 2017, 10:42 a.m., Ilya Pronin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57427/
> -----------------------------------------------------------
> 
> (Updated March 15, 2017, 10:42 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-2824
>     https://issues.apache.org/jira/browse/MESOS-2824
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added authorization for PULL_CONTAINER_IMAGE agent API call.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/acls.proto e75e1879435f1c2bce47a86e9feebf9d051e969b 
>   include/mesos/authorizer/authorizer.proto 736f76d552956f2351ffd40fc51d088dff83f8c8

>   src/authorizer/local/authorizer.cpp be8037299601427e5d5e79f58f77eea3f89579d0 
>   src/slave/http.cpp 1ab6f9475af287a6ac09bc615fa466223a52c97d 
>   src/tests/api_tests.cpp 29ae1bcf660fb0e03af1d2192484c9ec739f3ef6 
>   src/tests/authorization_tests.cpp cd15add7d7b01c2b316ac946e017a4d0b502237f 
> 
> 
> Diff: https://reviews.apache.org/r/57427/diff/2/
> 
> 
> Testing
> -------
> 
> Added `AuthorizationTest.PullContainerImage` and `AgentAPITest.PullContainerImageUnauthorized`
tests. Ran `make check`.
> 
> Verified manually by starting the agent with `--authenticate_http_readwrite` and sending
a call with curl as a principal that is allowed to `pull_container_image`.
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message