mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 56681: Use glog to log EXIT() messages.
Date Wed, 15 Mar 2017 21:45:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56681/#review169061
-----------------------------------------------------------



LGTM.

So in a couple of main.cpp files, this is used prior to glog initialization, which would result
in this warning "WARNING: Logging before InitGoogleLogging() is written to STDERR" but I feel
this is an improvement in general.

In "Testing Done", could you attach a sample output that confirms the format change?


3rdparty/stout/include/stout/exit.hpp
Line 26 (original), 25 (patched)
<https://reviews.apache.org/r/56681/#comment241378>

    s/provides a stream for output/provides a glog stream for output/
    
    So now that's it's using GLOG, the output rules are subject to the GLOG configuration.
Probably worth a brief mention since this detail is hidden under the interface.



3rdparty/stout/include/stout/exit.hpp
Line 36 (original), 35 (patched)
<https://reviews.apache.org/r/56681/#comment241377>

    `s/char */char*/`


- Jiang Yan Xu


On Feb. 14, 2017, 1:04 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56681/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2017, 1:04 p.m.)
> 
> 
> Review request for mesos and haosdent huang.
> 
> 
> Bugs: MESOS-7115
>     https://issues.apache.org/jira/browse/MESOS-7115
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Use glog to log EXIT() messages.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/exit.hpp 762864afd8f86f7e1f439ef6ea7e3965a5f147d5 
> 
> 
> Diff: https://reviews.apache.org/r/56681/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Fedora 25)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message