mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 57596: Kept TaskInfo beyond first scheduler ack in command executor.
Date Wed, 15 Mar 2017 20:48:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57596/
-----------------------------------------------------------

(Updated March 15, 2017, 8:48 p.m.)


Review request for mesos, Gastón Kleiman and Vinod Kone.


Bugs: MESOS-6906
    https://issues.apache.org/jira/browse/MESOS-6906


Repository: mesos


Description
-------

Prior to this patch, command executor wipes TaskInfo after receiving
a status update acknowledgement from the scheduler to indicate that
there are no unacknowledged tasks. Keeping original TaskInfo beyond
the ack can be beneficial, hence we introduce a struct TaskData that
holds TaskInfo and explicit ack flag.


Diffs (updated)
-----

  src/launcher/executor.cpp adcc50fb7df91b9f8dff0f583b61e0efcd6da378 


Diff: https://reviews.apache.org/r/57596/diff/3/

Changes: https://reviews.apache.org/r/57596/diff/2-3/


Testing
-------

See https://reviews.apache.org/r/56213/


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message