mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 56474: Added the 'CombinedAuthenticator'.
Date Wed, 15 Mar 2017 18:17:47 GMT


> On March 15, 2017, 1:50 p.m., Vinod Kone wrote:
> > include/mesos/authentication/http/combined_authenticator.hpp
> > Lines 123-130 (patched)
> > <https://reviews.apache.org/r/56474/diff/8/?file=1664836#file1664836line123>
> >
> >     why do we need the `overrides`? do we expect devs to subclass this in the future?

The `override` specifier is useful here because it tells the compiler that this function must
override a virtual function of the base class, otherwise the compiler will throw an error.
It prevents situations in which the signature of the base class function is changed but this
one is left the same, in which case this function would not override anything.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56474/#review168905
-----------------------------------------------------------


On March 15, 2017, 6:17 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56474/
> -----------------------------------------------------------
> 
> (Updated March 15, 2017, 6:17 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7004
>     https://issues.apache.org/jira/browse/MESOS-7004
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a new default authenticator, the
> `CombinedAuthenticator`, which can load multiple authenticators.
> It calls installed authenticators serially, returning the first
> successful result. When no results are successful, it returns a
> single result obtained by merging all unsuccessful results.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authentication/http/combined_authenticator.hpp PRE-CREATION 
>   src/CMakeLists.txt e1f81a17c0b007e84a5fc9827ef6b90bc276c267 
>   src/Makefile.am 2eea11a4f18f5d0e4ac3cc6bffc8b80f00556d01 
>   src/authentication/http/combined_authenticator.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/56474/diff/9/
> 
> 
> Testing
> -------
> 
> Testing information can be found in the subsequent patch in this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message