mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 56475: Added a test for the 'CombinedAuthenticator'.
Date Wed, 15 Mar 2017 14:08:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56475/#review169006
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/http_authentication_tests.cpp
Lines 284-286 (patched)
<https://reviews.apache.org/r/56475/#comment241337>

    can you not use the `Unauthorized` constructor that takes 2 arguments?



src/tests/http_authentication_tests.cpp
Lines 315-316 (patched)
<https://reviews.apache.org/r/56475/#comment241338>

    ditto. use 2 arg constructor?



src/tests/http_authentication_tests.cpp
Lines 379 (patched)
<https://reviews.apache.org/r/56475/#comment241339>

    // The first authenticator fails but the second one succeeds.



src/tests/http_authentication_tests.cpp
Lines 533 (patched)
<https://reviews.apache.org/r/56475/#comment241341>

    nice test!


- Vinod Kone


On March 14, 2017, 5:07 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56475/
> -----------------------------------------------------------
> 
> (Updated March 14, 2017, 5:07 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7004
>     https://issues.apache.org/jira/browse/MESOS-7004
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a unit test to verify the functionality of
> the `CombinedAuthenticator`. The new test is called
> `CombinedAuthenticatorTest.MultipleAuthenticators`.
> 
> 
> Diffs
> -----
> 
>   src/tests/http_authentication_tests.cpp 0eeed9d19881cf3fa5fec7fb7fedc1e92784f58b 
> 
> 
> Diff: https://reviews.apache.org/r/56475/diff/5/
> 
> 
> Testing
> -------
> 
> The following commands were used to test:
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*CombinedAuthenticator*" --gtest_repeat=-1 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message