mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 56476: Enabled loading multiple HTTP authenticators in Mesos.
Date Wed, 15 Mar 2017 13:57:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56476/#review169005
-----------------------------------------------------------


Fix it, then Ship it!





src/common/http.cpp
Line 964 (original), 957 (patched)
<https://reviews.apache.org/r/56476/#comment241335>

    This function is not "loading" the authenticator so logging so is a bit weird. maybe call
it "creating" or move this statement to `initializeAuthenticators`



src/common/http.cpp
Line 987 (original), 977 (patched)
<https://reviews.apache.org/r/56476/#comment241336>

    ditto. not "loading".


- Vinod Kone


On March 14, 2017, 5:07 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56476/
> -----------------------------------------------------------
> 
> (Updated March 14, 2017, 5:07 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7004
>     https://issues.apache.org/jira/browse/MESOS-7004
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the Mesos code to allow master and agent
> to load multiple HTTP authenticator modules.
> 
> 
> Diffs
> -----
> 
>   src/common/http.cpp 0848f70ad4fa9e67c74c9fbdd882d7ab5ed6eabf 
> 
> 
> Diff: https://reviews.apache.org/r/56476/diff/6/
> 
> 
> Testing
> -------
> 
> Still need to add tests which test the master and agent with multiple authenticator modules
loaded.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message