mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 57596: Kept TaskInfo beyond first scheduler ack in command executor.
Date Wed, 15 Mar 2017 13:31:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57596/#review169003
-----------------------------------------------------------


Fix it, then Ship it!





src/launcher/executor.cpp
Line 361 (original), 363 (patched)
<https://reviews.apache.org/r/57596/#comment241329>

    s/_task/task/



src/launcher/executor.cpp
Lines 860 (patched)
<https://reviews.apache.org/r/57596/#comment241330>

    s/received/received for any status updates/



src/launcher/executor.cpp
Lines 861 (patched)
<https://reviews.apache.org/r/57596/#comment241328>

    can you set this to false in the constructor initializer list instead?


- Vinod Kone


On March 15, 2017, 12:48 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57596/
> -----------------------------------------------------------
> 
> (Updated March 15, 2017, 12:48 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Vinod Kone.
> 
> 
> Bugs: MESOS-6906
>     https://issues.apache.org/jira/browse/MESOS-6906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Prior to this patch, command executor wipes TaskInfo after receiving
> a status update acknowledgement from the scheduler to indicate that
> there are no unacknowledged tasks. Keeping original TaskInfo beyond
> the ack can be beneficial, hence we introduce a struct TaskData that
> holds TaskInfo and explicit ack flag.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp adcc50fb7df91b9f8dff0f583b61e0efcd6da378 
> 
> 
> Diff: https://reviews.apache.org/r/57596/diff/2/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/56213/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message