mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 56017: Added a helper for building a task status from an existing one.
Date Wed, 15 Mar 2017 13:19:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56017/#review168999
-----------------------------------------------------------




src/common/protobuf_utils.hpp
Lines 96 (patched)
<https://reviews.apache.org/r/56017/#comment241325>

    The implementation doesn't create a new task sttus message. It updates the one passed
by the user.
    
    Given this behaviour, I find the method name and the comment misleading.


- Gastón Kleiman


On March 15, 2017, 12:44 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56017/
> -----------------------------------------------------------
> 
> (Updated March 15, 2017, 12:44 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/common/protobuf_utils.hpp 09e468c77f0cdd931302d1bdcc192370b6ce3340 
>   src/common/protobuf_utils.cpp 34c14e8ebd7b575627704c7edebcbb0458eeb3b1 
> 
> 
> Diff: https://reviews.apache.org/r/56017/diff/5/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message