mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 57622: Introduced a Roles tab in the webui.
Date Wed, 15 Mar 2017 02:05:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57622/
-----------------------------------------------------------

(Updated March 15, 2017, 2:05 a.m.)


Review request for mesos, Jay Guo, Michael Park, and Neil Conway.


Changes
-------

Fixed an issue where the roles tab is not shown as active (this was due to following the approach
used in the maintenance tab, where it's also broken).


Bugs: MESOS-6995
    https://issues.apache.org/jira/browse/MESOS-6995


Repository: mesos


Description
-------

Initially, this includes the weight, number of frameworks involved
with the role, and the resource allocation. Longer term this should
include the quota information and the revocable resources.


Diffs (updated)
-----

  src/Makefile.am 2eea11a4f18f5d0e4ac3cc6bffc8b80f00556d01 
  src/webui/master/static/index.html 7811ecb2c8c4fc5d14c4d5ca690b611290b07c83 
  src/webui/master/static/js/app.js 73043a8521d2931b639ece11bf3f2b8bccba83d6 
  src/webui/master/static/js/controllers.js 4e1d07eb6155301c7d7d2b3e030c38156e8210ad 
  src/webui/master/static/roles.html PRE-CREATION 


Diff: https://reviews.apache.org/r/57622/diff/3/

Changes: https://reviews.apache.org/r/57622/diff/2-3/


Testing
-------

manual testing.


File Attachments
----------------

screenshot
  https://reviews.apache.org/media/uploaded/files/2017/03/14/2670df08-47f2-4cbf-8c61-1f897c19fa1c__Screen_Shot_2017-03-14_at_3.26.06_PM.png


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message