mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 57427: Added authorization for PULL_CONTAINER_IMAGE agent API call.
Date Wed, 15 Mar 2017 01:45:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57427/#review168963
-----------------------------------------------------------



Bad patch!

Reviews applied: [57427, 57426, 57425]

Failed command: python support/apply-reviews.py -n -r 57425

Error:
2017-03-15 01:45:35 URL:https://reviews.apache.org/r/57425/diff/raw/ [9700/9700] -> "57425.patch"
[1]
error: patch failed: src/slave/containerizer/containerizer.hpp:151
error: src/slave/containerizer/containerizer.hpp: patch does not apply
error: patch failed: src/slave/containerizer/mesos/containerizer.hpp:114
error: src/slave/containerizer/mesos/containerizer.hpp: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/17437/console

- Mesos Reviewbot


On March 14, 2017, 5:57 p.m., Ilya Pronin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57427/
> -----------------------------------------------------------
> 
> (Updated March 14, 2017, 5:57 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-2824
>     https://issues.apache.org/jira/browse/MESOS-2824
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added authorization for PULL_CONTAINER_IMAGE agent API call.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/acls.proto 8389917d12f9a9a3c9b4281f48e23ade14c20528 
>   include/mesos/authorizer/authorizer.proto fdc4817ce74c45d792fc47f064f7909a83b1657d

>   src/authorizer/local/authorizer.cpp 2227b241eab1606815fa6464e3d6b1345624fd22 
>   src/slave/http.cpp bc8209cb81194ebc8b604c9ba0d4a9e176cff2f6 
>   src/tests/api_tests.cpp 52f58a4d6b1ea75744de1c3d2f0f064d9299fe1d 
>   src/tests/authorization_tests.cpp 42edecc794b71a00ca32d26ae9b74e9f3ef97510 
> 
> 
> Diff: https://reviews.apache.org/r/57427/diff/1/
> 
> 
> Testing
> -------
> 
> Added `AuthorizationTest.PullContainerImage` and `AgentAPITest.PullContainerImageUnauthorized`
tests. Ran `make check`.
> 
> Verified manually by starting the agent with `--authenticate_http_readwrite` and sending
a call with curl as a principal that is allowed to `pull_container_image`.
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message