mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 53264: Added test for CNI port-mapper plugin.
Date Tue, 14 Mar 2017 23:14:41 GMT


> On Feb. 28, 2017, 4:42 a.m., Jie Yu wrote:
> > src/tests/containerizer/cni_isolator_tests.cpp
> > Lines 1093-1097 (patched)
> > <https://reviews.apache.org/r/53264/diff/3/?file=1650779#file1650779line1093>
> >
> >     Instead of that, can we use `__MESOS_TEST__2`?
> 
> Avinash sridharan wrote:
>     Hi Jie, 
>     Sorry for the delay here. We will need to change the `network/cni` isolator for this
right? Didn't really see a reason for this since replacing the existing CNI config would just
work the same. Will keep the logic in the `network/cni` isolator simpler?
> 
> Jie Yu wrote:
>     I thought we already do 'contains' check in CNI isolator?
> 
> Avinash sridharan wrote:
>     https://github.com/apache/mesos/blob/7c3c0b03a8371922f6cc811ad74d85c97eefb494/src/slave/containerizer/mesos/isolators/network/cni/cni.cpp#L693
>     
>     I think you are referring to using `strings::contains`. No unfortunately haven't
added that to the `network/cni` isolator.
> 
> Jie Yu wrote:
>     Can we do that. I remember you already have the patch?
> 
> Avinash sridharan wrote:
>     We were planning to do that for the tests for dynamically `add/delete/modify` CNI
configuration, but as in this case it turned out we didn't need to so ended up not implementing
it. Let me see if I can do it as part of this ticket.

Created a separate patch for the changes to the `network/cni` isolator.


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53264/#review166956
-----------------------------------------------------------


On March 14, 2017, 11:13 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53264/
> -----------------------------------------------------------
> 
> (Updated March 14, 2017, 11:13 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-6022
>     https://issues.apache.org/jira/browse/MESOS-6022
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test for CNI port-mapper plugin.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cni_isolator_tests.cpp cb893d3ef005a9cc60c40768fa669b27c4863020

> 
> 
> Diff: https://reviews.apache.org/r/53264/diff/6/
> 
> 
> Testing
> -------
> 
> sudo ./bin/mesos-tests.sh --gtest_filter=CniIsolator*.*
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message