mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 57491: Windows: Update libprocess CMake setup for Glog patch.
Date Tue, 14 Mar 2017 18:57:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57491/#review168929
-----------------------------------------------------------


Ship it!




I can fix those above nits before committing.

- Joseph Wu


On March 9, 2017, 5:59 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57491/
> -----------------------------------------------------------
> 
> (Updated March 9, 2017, 5:59 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-6815
>     https://issues.apache.org/jira/browse/MESOS-6815
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The additional Windows library `Dbghelp` must be linked for the
> patches enabling stack traces.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake e9eabd08d327f4c714199f7bde91b9adf644a678

> 
> 
> Diff: https://reviews.apache.org/r/57491/diff/1/
> 
> 
> Testing
> -------
> 
> Run CTest. Add purposefully failing test, observe stack trace.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message