mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 57574: Ensured the cgroup memory+swap limit is no less than the memory limit.
Date Tue, 14 Mar 2017 05:01:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57574/#review168863
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp
Lines 214-221 (original), 214-221 (patched)
<https://reviews.apache.org/r/57574/#comment241153>

    Move these comments down to line 273?



src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp
Lines 266-271 (patched)
<https://reviews.apache.org/r/57574/#comment241155>

    Move this to line 282 right above the conditional. It helps understand the order of the
functions set better.



src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp
Lines 284 (patched)
<https://reviews.apache.org/r/57574/#comment241156>

    Just for clarification maybe add a note:
    
    ```
    NOTE: The memory limit is already set to the max, so effectively we are reducing the memory
limits because of which we need to set the 'memory.limit_in_bytes' before setting 'memory.memsw.limit_in_bytes'


- Avinash sridharan


On March 14, 2017, 12:04 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57574/
> -----------------------------------------------------------
> 
> (Updated March 14, 2017, 12:04 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, haosdent huang, Ian Downes, and Kevin Klues.
> 
> 
> Bugs: MESOS-7237
>     https://issues.apache.org/jira/browse/MESOS-7237
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This addressed the bug we saw in MESOS-7237. Linux kernel will ensure
> cgroup memory+swap limit (i.e., 'memory.memsw.limit_in_bytes') is always
> no less than the memory limit ('memory.limit_in_bytes'). Prior to this
> patch, the memory subsystem in the cgroups isolator is buggy because
> memory+swap limit is always changed after the memory limit. This will
> cause EINVAL if we increase the memory limit of the container.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp 009e996add25e43e8989600a58b38f2cc88a5d11

> 
> 
> Diff: https://reviews.apache.org/r/57574/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message