mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Review Request 57574: Ensured the cgroup memory+swap limit is no less than the memory limit.
Date Tue, 14 Mar 2017 00:04:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57574/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler, haosdent huang, Ian Downes, and Kevin Klues.


Bugs: MESOS-7237
    https://issues.apache.org/jira/browse/MESOS-7237


Repository: mesos


Description
-------

This addressed the bug we saw in MESOS-7237. Linux kernel will ensure
cgroup memory+swap limit (i.e., 'memory.memsw.limit_in_bytes') is always
no less than the memory limit ('memory.limit_in_bytes'). Prior to this
patch, the memory subsystem in the cgroups isolator is buggy because
memory+swap limit is always changed after the memory limit. This will
cause EINVAL if we increase the memory limit of the container.


Diffs
-----

  src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp 009e996add25e43e8989600a58b38f2cc88a5d11



Diff: https://reviews.apache.org/r/57574/diff/1/


Testing
-------

sudo make check


Thanks,

Jie Yu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message