mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 57269: Added a test to ensure allocation roles are exposed in master API.
Date Mon, 13 Mar 2017 22:22:46 GMT


> On March 6, 2017, 10:38 p.m., Benjamin Mahler wrote:
> > src/tests/master_tests.cpp
> > Lines 4292-4293 (patched)
> > <https://reviews.apache.org/r/57269/diff/1/?file=1655331#file1655331line4292>
> >
> >     Are you planning to test the agent endpoint as well?
> 
> Jay Guo wrote:
>     I modified existing test to include this https://github.com/apache/mesos/blob/master/src/tests/slave_tests.cpp#L1645-L1663
do you think that's no sufficient?

Oh right, that seems sufficient, but we should use the same test approach for this across
both agent and master.

Right now, the agent side is tested within SlaveTest.StateEndpoint, but the master side is
tested within its own test MasterTest.StateEndpointAllocationRole. Why not also have a SlaveTest.StateEndpointAllocationRole
test?


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57269/#review168058
-----------------------------------------------------------


On March 13, 2017, 2:43 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57269/
> -----------------------------------------------------------
> 
> (Updated March 13, 2017, 2:43 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7158
>     https://issues.apache.org/jira/browse/MESOS-7158
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test ensures that allocation roles of tasks and executors are
> exposed via `/state` endpoint of master v0 API.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp cacb5566cd40ab57a9c72ad02f75e84c451d08b6 
> 
> 
> Diff: https://reviews.apache.org/r/57269/diff/5/
> 
> 
> Testing
> -------
> 
> Added a test `MasterTest.StateEndpointAllocationRole`
> 
> make check
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message