mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 57472: Removing deprecated ACLs `SetQuota` and `RemoveQuota`.
Date Mon, 13 Mar 2017 21:23:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57472/#review168830
-----------------------------------------------------------


Fix it, then Ship it!





CHANGELOG
Lines 5-9 (patched)
<https://reviews.apache.org/r/57472/#comment241075>

    IIRC, we usually copy the ticket title first and then write a description if necessary.
However, there is probably an even better solution. We've recently started to track deprecations
in JIRA: https://issues.apache.org/jira/browse/MESOS-7134?jql=project%20%3D%20MESOS%20AND%20labels%20%3D%20deprecation
    
    So how about creating a separate ticket for this patch?



docs/upgrades.md
Lines 261-263 (patched)
<https://reviews.apache.org/r/57472/#comment241078>

    Let's say how they should update the cluster.
    
    ```
    * When upgrading a Mesos cluster that uses the `set_quotas` or `remove_quotas` ACLs, the
operator should first upgrade the Mesos binaries. At this point, the deprecated ACLs will
still be enforced. After the upgrade has been verified, the operator should replace deprecated
values for `set_quotas` and `remove_quotas` with equivalent values for `update_quotas`;
    ```



include/mesos/authorizer/acls.proto
Lines 406-409 (original)
<https://reviews.apache.org/r/57472/#comment241077>

    Do we usually keep a comment saying that tags `9` and `10` are not allowed to be used
any more?



src/master/master.hpp
Lines 1060-1064 (original), 1060-1064 (patched)
<https://reviews.apache.org/r/57472/#comment241083>

    Kill the comment.


- Alexander Rukletsov


On March 13, 2017, 12:48 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57472/
> -----------------------------------------------------------
> 
> (Updated March 13, 2017, 12:48 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The ACLs `SetQuota` and `RemoveQuota` where marked for deprecation
> more than six months ago, where they were replaced for the more
> convenient `UpdateQuota` ACL. The deprecation cycle for these actions
> is finally due while at the same time removing will make easier to
> implement the hierarchical role feature in a generic way.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 0a4e1dd52f9197151c5ef4318579ffa4e9bcf0ee 
>   docs/upgrades.md e7f95aadeee330b3a9dbafc0f716c13df1bc8252 
>   include/mesos/authorizer/acls.proto 8389917d12f9a9a3c9b4281f48e23ade14c20528 
>   src/authorizer/local/authorizer.cpp 2227b241eab1606815fa6464e3d6b1345624fd22 
>   src/master/master.hpp d92c8adef79d997f255cf26ebd10ab0e87da8413 
>   src/master/quota_handler.cpp 36ea1acca47014b2fb7a3b597b857c8ec9e2ab67 
>   src/tests/authorization_tests.cpp 42edecc794b71a00ca32d26ae9b74e9f3ef97510 
>   src/tests/master_quota_tests.cpp e418f22ea1773f4356ced44b8d57a80e826c8837 
> 
> 
> Diff: https://reviews.apache.org/r/57472/diff/3/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message