mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 57384: Added `Containerizer::remove`.
Date Mon, 13 Mar 2017 12:33:40 GMT


> On March 9, 2017, 9:16 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/containerizer.cpp
> > Lines 2395-2396 (patched)
> > <https://reviews.apache.org/r/57384/diff/3/?file=1660152#file1660152line2395>
> >
> >     Error message here should not include 'containerId' because that's the responsibility
of the caller.
> >     
> >     Ditto elsewhere.

`MesosContainerizerProcess::launch()` includes the `containerId` in the failure messages,
I tried to be consistent with it.

Should we remove the `containerId` from those failures as well?


- Gastón


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57384/#review168515
-----------------------------------------------------------


On March 13, 2017, 12:32 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57384/
> -----------------------------------------------------------
> 
> (Updated March 13, 2017, 12:32 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-7120
>     https://issues.apache.org/jira/browse/MESOS-7120
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This new method removes the sandbox and runtime directories of a
> terminated nested container.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/containerizer.hpp f65a9b9761fc254bd0778bf13aac9b256497b22f

>   src/slave/containerizer/mesos/containerizer.hpp 09f94ccb3224c14a9324961b789455b119ec2257

>   src/slave/containerizer/mesos/containerizer.cpp 7676a4d8a35f2239c7373b0a9e76fa343b322f62

>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp ea01fe55a28d17105157004d8cf0976202a49b7c

> 
> 
> Diff: https://reviews.apache.org/r/57384/diff/5/
> 
> 
> Testing
> -------
> 
> Added a test and verified that it works on Linux.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message