mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 53074: Updated pylint to rebuild 'virtualenv' if pip-requirements.txt modified.
Date Sun, 12 Mar 2017 23:33:58 GMT


> On Oct. 25, 2016, 10:42 p.m., Joseph Wu wrote:
> > support/mesos-style.py
> > Lines 297 (patched)
> > <https://reviews.apache.org/r/53074/diff/1/?file=1542457#file1542457line319>
> >
> >     Perhaps we should also check for modifications to the `mesos.bash_completion`
file.  AFAICS, these are the only two files that get used/copied while setting up the virtualenv.

I agree. I've updated this accordingly.


> On Oct. 25, 2016, 10:42 p.m., Joseph Wu wrote:
> > support/mesos-style.py
> > Lines 311-312 (patched)
> > <https://reviews.apache.org/r/53074/diff/1/?file=1542457#file1542457line333>
> >
> >     This effectively bypasses the virtualenv check you have inside the bootstrap
script.  But at this point in the script, the linter should not have entered the virtualenv
yet.  Meaning that the bootstrap script's check should still be run.

Agreed. The original reasoning for this was so that you could rebuild the virtualenv even
if you had one currently activated. This seems sneaky though (and possibly undesirable). I've
removed these two lines altogether now. Now it will error out telling you to deactivate your
currnet virtualenv in order to continue.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53074/#review153832
-----------------------------------------------------------


On Oct. 20, 2016, 6:10 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53074/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2016, 6:10 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-6430
>     https://issues.apache.org/jira/browse/MESOS-6430
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated pylint to rebuild 'virtualenv' if pip-requirements.txt modified.
> 
> 
> Diffs
> -----
> 
>   support/mesos-style.py 3a5bec81950ccf8083cbd73577c49b2fb3b910f8 
> 
> 
> Diff: https://reviews.apache.org/r/53074/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message