mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 53264: Added test for CNI port-mapper plugin.
Date Sun, 12 Mar 2017 07:14:38 GMT


> On Feb. 28, 2017, 4:42 a.m., Jie Yu wrote:
> > src/tests/containerizer/cni_isolator_tests.cpp
> > Lines 1207-1209 (patched)
> > <https://reviews.apache.org/r/53264/diff/3/?file=1650779#file1650779line1207>
> >
> >     I'd suggest we don't directly check ip table rules. I think using curl below
is sufficient.

Any specific reason for not checking the iptable rules? I wanted to strengthen the test by
making sure the iptable rules installed are what is expected, and the installed iptable rules
actually result in the correct port mapping (tested by curl). Hence, would like to keep the
iptables check unless you feel it might make the test flaky.


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53264/#review166956
-----------------------------------------------------------


On March 12, 2017, 7:11 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53264/
> -----------------------------------------------------------
> 
> (Updated March 12, 2017, 7:11 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-6022
>     https://issues.apache.org/jira/browse/MESOS-6022
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test for CNI port-mapper plugin.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cni_isolator_tests.cpp cb893d3ef005a9cc60c40768fa669b27c4863020

> 
> 
> Diff: https://reviews.apache.org/r/53264/diff/4/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message