mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 57513: Cleaned up `strings::tokenize` and `strings::split`.
Date Fri, 10 Mar 2017 21:16:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57513/#review168674
-----------------------------------------------------------



Bad review!

Reviews applied: [57513, 57512, 57511, 57510, 57516, 57254, 57167, 57166, 56805, 57165, 57164]

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.

- Mesos Reviewbot


On March 10, 2017, 5:05 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57513/
> -----------------------------------------------------------
> 
> (Updated March 10, 2017, 5:05 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The previous coding used a `while` loop condition that was invariant
> over the body of the loop; it is clearer to write this as an `if`
> statement instead.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/strings.hpp fe469fa492f179d42794a8ce8f75c0654be7ef58 
> 
> 
> Diff: https://reviews.apache.org/r/57513/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message