mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 56475: Added a test for the 'CombinedAuthenticator'.
Date Fri, 10 Mar 2017 20:41:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56475/#review168663
-----------------------------------------------------------




src/tests/http_authentication_tests.cpp
Lines 295-298 (patched)
<https://reviews.apache.org/r/56475/#comment240941>

    Factor this out above



src/tests/http_authentication_tests.cpp
Lines 318-320 (patched)
<https://reviews.apache.org/r/56475/#comment240945>

    Could add helper to construct the results for mock authenticators



src/tests/http_authentication_tests.cpp
Lines 342-343 (patched)
<https://reviews.apache.org/r/56475/#comment240940>

    Construct these using member `scheme` from mock authenticators?



src/tests/http_authentication_tests.cpp
Lines 407 (patched)
<https://reviews.apache.org/r/56475/#comment240922>

    Multiple empty


- Greg Mann


On March 10, 2017, 12:35 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56475/
> -----------------------------------------------------------
> 
> (Updated March 10, 2017, 12:35 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7004
>     https://issues.apache.org/jira/browse/MESOS-7004
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a unit test to verify the functionality of
> the `CombinedAuthenticator`. The new test is called
> `CombinedAuthenticatorTest.MultipleAuthenticators`.
> 
> 
> Diffs
> -----
> 
>   src/tests/http_authentication_tests.cpp d5fabf0058755502f19eb6385bd99a0d45419508 
> 
> 
> Diff: https://reviews.apache.org/r/56475/diff/3/
> 
> 
> Testing
> -------
> 
> The following commands were used to test:
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*CombinedAuthenticator*" --gtest_repeat=-1 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message