mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 56476: Enabled loading multiple HTTP authenticators in Mesos.
Date Fri, 10 Mar 2017 20:32:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56476/#review168667
-----------------------------------------------------------




src/common/http.cpp
Line 975 (original), 965 (patched)
<https://reviews.apache.org/r/56476/#comment240938>

    Custom authenticator case



src/common/http.cpp
Lines 996 (patched)
<https://reviews.apache.org/r/56476/#comment240937>

    s/tryAuthenticator/authenticator_/



src/common/http.cpp
Lines 996-997 (patched)
<https://reviews.apache.org/r/56476/#comment240939>

    create two helpers, one for basic and one for modules (later for JWT)



src/common/http.cpp
Line 991 (original), 1001 (patched)
<https://reviews.apache.org/r/56476/#comment240933>

    s/Could not create/Failed to create/



src/common/http.cpp
Lines 1011 (patched)
<https://reviews.apache.org/r/56476/#comment240935>

    s/tryAuthenticator/authenticator_/



src/common/http.cpp
Lines 1016 (patched)
<https://reviews.apache.org/r/56476/#comment240934>

    s/Could not create/Failed to create/



src/common/http.cpp
Lines 1023-1024 (patched)
<https://reviews.apache.org/r/56476/#comment240936>

    Remove comment


- Greg Mann


On March 9, 2017, 11:41 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56476/
> -----------------------------------------------------------
> 
> (Updated March 9, 2017, 11:41 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7004
>     https://issues.apache.org/jira/browse/MESOS-7004
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the Mesos code to allow master and agent
> to load multiple HTTP authenticator modules.
> 
> 
> Diffs
> -----
> 
>   src/common/http.cpp 0848f70ad4fa9e67c74c9fbdd882d7ab5ed6eabf 
> 
> 
> Diff: https://reviews.apache.org/r/56476/diff/4/
> 
> 
> Testing
> -------
> 
> Still need to add tests which test the master and agent with multiple authenticator modules
loaded.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message