mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 56474: Added the 'CombinedAuthenticator'.
Date Fri, 10 Mar 2017 20:22:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56474/#review168657
-----------------------------------------------------------




include/mesos/authentication/http/combined_authenticator.hpp
Lines 46-50 (patched)
<https://reviews.apache.org/r/56474/#comment240900>

    Remove?



include/mesos/authentication/http/combined_authenticator.hpp
Lines 64 (patched)
<https://reviews.apache.org/r/56474/#comment240902>

    s/authenticator modules/authenticators/



include/mesos/authentication/http/combined_authenticator.hpp
Lines 69-79 (patched)
<https://reviews.apache.org/r/56474/#comment240906>

    "If the `unauthorized` member is set on any received results, an Unauthorized result will
be returned" or similar.
    
    Provide examples.



include/mesos/authentication/http/combined_authenticator.hpp
Lines 70 (patched)
<https://reviews.apache.org/r/56474/#comment240903>

    s/modules'/authenticators'/



src/authentication/http/combined_authenticator.cpp
Lines 23 (patched)
<https://reviews.apache.org/r/56474/#comment240914>

    remove?



src/authentication/http/combined_authenticator.cpp
Lines 33 (patched)
<https://reviews.apache.org/r/56474/#comment240913>

    remove?



src/authentication/http/combined_authenticator.cpp
Lines 66-68 (patched)
<https://reviews.apache.org/r/56474/#comment240916>

    Move below.



src/authentication/http/combined_authenticator.cpp
Lines 81-86 (patched)
<https://reviews.apache.org/r/56474/#comment240931>

    Refactor to use `strings::join` on containers of headers/bodies



src/authentication/http/combined_authenticator.cpp
Lines 83 (patched)
<https://reviews.apache.org/r/56474/#comment240923>

    s/Option<AuthenticationResult>/AuthenticationResult/



src/authentication/http/combined_authenticator.cpp
Lines 84 (patched)
<https://reviews.apache.org/r/56474/#comment240924>

    `combineFailed()` instead?



src/authentication/http/combined_authenticator.cpp
Lines 89 (patched)
<https://reviews.apache.org/r/56474/#comment240926>

    Make this more explicit



src/authentication/http/combined_authenticator.cpp
Lines 92 (patched)
<https://reviews.apache.org/r/56474/#comment240925>

    CHECK_NONE(result.principal)



src/authentication/http/combined_authenticator.cpp
Lines 181-182 (patched)
<https://reviews.apache.org/r/56474/#comment240917>

    s/If we've reached the end of the authenticator vector, then //



src/authentication/http/combined_authenticator.cpp
Lines 187-188 (patched)
<https://reviews.apache.org/r/56474/#comment240919>

    Add a test with an authenticator returning a `Failure`.



src/authentication/http/combined_authenticator.cpp
Lines 199-200 (patched)
<https://reviews.apache.org/r/56474/#comment240920>

    Log the scheme here.


- Greg Mann


On March 10, 2017, 5:49 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56474/
> -----------------------------------------------------------
> 
> (Updated March 10, 2017, 5:49 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7004
>     https://issues.apache.org/jira/browse/MESOS-7004
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a new default authenticator, the
> `CombinedAuthenticator`, which can load multiple authenticators.
> It calls installed authenticators serially, returning the first
> successful result. When no results are successful, it returns a
> single result obtained by merging all unsuccessful results.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authentication/http/combined_authenticator.hpp PRE-CREATION 
>   src/Makefile.am bb917c5d1b36f5106a74914fa3a864038a95e8bb 
>   src/authentication/http/combined_authenticator.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/56474/diff/5/
> 
> 
> Testing
> -------
> 
> Testing information can be found in the subsequent patch in this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message