-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56754/#review168653
-----------------------------------------------------------
src/authentication/executor/jwt_secret_generator.hpp
Lines 17-18 (patched)
<https://reviews.apache.org/r/56754/#comment240895>
Use entire path here? `MESOS_AUTHENTICATION_EXECUTOR_JWT_SECRET_GENERATOR_HPP`
Double-check on other headers as well.
- Greg Mann
On March 10, 2017, 11:27 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56754/
> -----------------------------------------------------------
>
> (Updated March 10, 2017, 11:27 a.m.)
>
>
> Review request for mesos, Alexander Rojas and Greg Mann.
>
>
> Bugs: MESOS-7000
> https://issues.apache.org/jira/browse/MESOS-7000
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This can be used to create a 'Secret' from a 'Principal'.
> The resulting secret will provide a JWT.
>
>
> Diffs
> -----
>
> src/Makefile.am bb917c5d1b36f5106a74914fa3a864038a95e8bb
> src/authentication/executor/jwt_secret_generator.hpp PRE-CREATION
> src/authentication/executor/jwt_secret_generator.cpp PRE-CREATION
> src/tests/secret_generator_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/56754/diff/9/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
|