mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 56474: Added the 'CombinedAuthenticator'.
Date Fri, 10 Mar 2017 17:49:37 GMT


> On March 10, 2017, 12:50 p.m., Jan Schlicht wrote:
> > src/authentication/http/combined_authenticator.cpp
> > Lines 172 (patched)
> > <https://reviews.apache.org/r/56474/diff/4/?file=1660838#file1660838line172>
> >
> >     Is it okay to capture `this` here? I just remembered (MESOS-5629)[https://issues.apache.org/jira/browse/MESOS-5629]
but didn't closely follow the discussion. Feel free to drop this one, if the capture isn't
an issue.

Ah, thank you for catching this! Updated to copy `self()` and capture that instead.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56474/#review168602
-----------------------------------------------------------


On March 10, 2017, 5:49 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56474/
> -----------------------------------------------------------
> 
> (Updated March 10, 2017, 5:49 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7004
>     https://issues.apache.org/jira/browse/MESOS-7004
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a new default authenticator, the
> `CombinedAuthenticator`, which can load multiple authenticators.
> It calls installed authenticators serially, returning the first
> successful result. When no results are successful, it returns a
> single result obtained by merging all unsuccessful results.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authentication/http/combined_authenticator.hpp PRE-CREATION 
>   src/Makefile.am bb917c5d1b36f5106a74914fa3a864038a95e8bb 
>   src/authentication/http/combined_authenticator.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/56474/diff/5/
> 
> 
> Testing
> -------
> 
> Testing information can be found in the subsequent patch in this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message