mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 57341: Made the usage of C++ namespaces in 'slave/http.cpp' consistent.
Date Fri, 10 Mar 2017 16:06:34 GMT


> On March 9, 2017, 9:20 p.m., Jie Yu wrote:
> > What's the reason for this change? Can I get some context?
> 
> Vinod Kone wrote:
>     I think Gaston wanted calls in slave/http.cpp to look similar to how they were defined
in master/http.cpp. The original inconsistency is because in master/http.cpp, we needed the
fully qualified namespace because compiler gets confused between `mesos::internal::master`
namespace and `mesos::master` namespace. We didn't need it slave/http.cpp because the namespaces
are `mesos::internal::slave` and `mesos::agent`.

That's right, I first wanted to fix inconsistencies in `slave/http.cpp` like the following:

```
    case agent::Call::KILL_NESTED_CONTAINER:
      return killNestedContainer(call, mediaTypes.accept, principal);

    case mesos::agent::Call::LAUNCH_NESTED_CONTAINER_SESSION:
      return launchNestedContainerSession(call, mediaTypes, principal);
```

I looked at what we do in `master/http.cpp` in order to decide between `agent::Call` and `mesos::agent::Call`.


- Gastón


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57341/#review168523
-----------------------------------------------------------


On March 8, 2017, 11:11 a.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57341/
> -----------------------------------------------------------
> 
> (Updated March 8, 2017, 11:11 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Bugs: MESOS-7120
>     https://issues.apache.org/jira/browse/MESOS-7120
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Followed the convention in 'master/http.cpp' and explicitly used the
> 'mesos::' prefix.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp bc8209cb81194ebc8b604c9ba0d4a9e176cff2f6 
> 
> 
> Diff: https://reviews.apache.org/r/57341/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message