-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56753/#review168533
-----------------------------------------------------------
3rdparty/libprocess/include/process/authenticator.hpp
Lines 151 (patched)
<https://reviews.apache.org/r/56753/#comment240773>
Perhaps this should go toward the beginning of the file with the forward declaration of
`BasicAuthenticatorProcess`.
3rdparty/libprocess/src/tests/http_tests.cpp
Lines 2032 (patched)
<https://reviews.apache.org/r/56753/#comment240777>
s/credentials/'Authorization' header/
to be consistent with the comment below
3rdparty/libprocess/src/tests/http_tests.cpp
Lines 2039 (patched)
<https://reviews.apache.org/r/56753/#comment240778>
s/header/'Authorization' header/
- Greg Mann
On March 9, 2017, 2:51 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56753/
> -----------------------------------------------------------
>
> (Updated March 9, 2017, 2:51 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Greg Mann.
>
>
> Bugs: MESOS-7001
> https://issues.apache.org/jira/browse/MESOS-7001
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This HTTP authenticator extracts a JWT from the requests' authorization
> header using the 'Bearer' schema and validates it against a secret using
> HMAC SHA256. The 'sub' claim of the JWT is the extracted principal, all
> other claims will be additional labels of the 'Principal'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am 75386184108214e67a58c328258ec204099d638c
> 3rdparty/libprocess/include/process/authenticator.hpp 00660f42cd4b707d955745bbfea5ffec73f690d6
> 3rdparty/libprocess/src/jwt_authenticator.cpp PRE-CREATION
> 3rdparty/libprocess/src/tests/http_tests.cpp a0e23c2300f9f6b9d1143ee1eb115bbf24adf92e
>
>
> Diff: https://reviews.apache.org/r/56753/diff/7/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
|