mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 56730: Kill stray tasks when tearing down test cgroups.
Date Thu, 09 Mar 2017 00:03:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56730/
-----------------------------------------------------------

(Updated March 9, 2017, 12:03 a.m.)


Review request for mesos, haosdent huang, Jie Yu, and Jiang Yan Xu.


Changes
-------

Added comments and consistent error handling.


Bugs: MESOS-7049
    https://issues.apache.org/jira/browse/MESOS-7049


Repository: mesos


Description
-------

If a test case fails, it may leave stray tasks in the cgroup which keeps
us from tearing it down when the test completes. Kill any stray tasks
before destroying the cgroup.


Diffs (updated)
-----

  src/tests/containerizer/cgroups_tests.cpp 76fabce4530ccc0a1d685cd48d932ced5a64bc58 
  src/tests/mesos.cpp 6a96fa51dfc2a62063c3154b256bdac707b009bb 


Diff: https://reviews.apache.org/r/56730/diff/2/

Changes: https://reviews.apache.org/r/56730/diff/1-2/


Testing
-------

sudo make check (Fedora 25)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message