mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 56027: Consistently add the FollowSymlink stat argument on POSIX.
Date Wed, 08 Mar 2017 22:42:43 GMT


> On March 8, 2017, 5:27 p.m., Michael Park wrote:
> > 3rdparty/stout/include/stout/os/posix/stat.hpp
> > Line 30 (original), 30 (patched)
> > <https://reviews.apache.org/r/56027/diff/1/?file=1617902#file1617902line30>
> >
> >     Do we want to return a `Try<::stat>` here, maybe? This way we can also
factor out the
> >     ```cpp
> >     "Error invoking stat for '" + path + "'"
> >     ```
> >     message here.

There's ~20 places that depend on this returning boolean. Returning `Try` would complicate
many of these call sites.


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56027/#review168311
-----------------------------------------------------------


On Feb. 2, 2017, 12:46 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56027/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2017, 12:46 a.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joris Van Remoortere, Joseph Wu, Michael Park,
and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7021
>     https://issues.apache.org/jira/browse/MESOS-7021
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Consistently add the FollowSymlink stat argument on POSIX.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/posix/stat.hpp e7440a4dab82ca3758a60a8fdc859476b2ee5693

>   3rdparty/stout/include/stout/os/stat.hpp 5c4fd4e630459059fa94c9f98e0d9b73d1280918 
> 
> 
> Diff: https://reviews.apache.org/r/56027/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Fedora 25)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message