mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 56667: Added support for JSON Web Tokens.
Date Wed, 08 Mar 2017 19:43:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56667/#review168328
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/src/jwt.cpp
Lines 37 (patched)
<https://reviews.apache.org/r/56667/#comment240544>

    Should the 3 helpers here be either enclosed in an anonymous namespace or decorated with
`static`?



3rdparty/libprocess/src/jwt.cpp
Lines 42 (patched)
<https://reviews.apache.org/r/56667/#comment240545>

    "Failed to base64url decode" might be more informative here?



3rdparty/libprocess/src/jwt.cpp
Lines 168-170 (patched)
<https://reviews.apache.org/r/56667/#comment240548>

    If you want to improve the encapsulation of the error messages a bit, you could prefix
with "Parsing token header failed: " here, and remove specific references to the header from
the error messages returned by `parse_header`. Could do a similar thing with `parse_payload`.
Up to you.



3rdparty/libprocess/src/jwt.cpp
Lines 228 (patched)
<https://reviews.apache.org/r/56667/#comment240546>

    s/base64/base64url/



3rdparty/libprocess/src/jwt.cpp
Lines 248 (patched)
<https://reviews.apache.org/r/56667/#comment240547>

    Remove period at end of this error message


- Greg Mann


On March 8, 2017, 2:23 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56667/
> -----------------------------------------------------------
> 
> (Updated March 8, 2017, 2:23 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Greg Mann.
> 
> 
> Bugs: MESOS-7001
>     https://issues.apache.org/jira/browse/MESOS-7001
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> JSON Web Tokens can be used to create claim-based access tokens and is
> typically used for HTTP authentication.
> This implementation is intended for internal use, e.g. Mesos is supposed
> to only parse tokens that it also created. It doesn't fully comply with
> RFC 7519. Currently the only supported cryptographic algorithm is HMAC
> with SHA-256.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am 75386184108214e67a58c328258ec204099d638c 
>   3rdparty/libprocess/include/process/jwt.hpp PRE-CREATION 
>   3rdparty/libprocess/src/jwt.cpp PRE-CREATION 
>   3rdparty/libprocess/src/tests/jwt_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/56667/diff/8/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message