mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 56028: Consistently add the FollowSymlink stat argument on Windows.
Date Wed, 08 Mar 2017 17:30:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56028/#review168313
-----------------------------------------------------------




3rdparty/stout/include/stout/os/windows/stat.hpp
Line 112 (original), 119-121 (patched)
<https://reviews.apache.org/r/56028/#comment240531>

    Do we not also want to error out here?
    ```cpp
      if (follow == DO_NOT_FOLLOW_SYMLINK) {
          return WindowsError(
              ERROR_NOT_SUPPORTED,
              "Error invoking stat for '" + path + "'");
      }
    ```


- Michael Park


On Feb. 1, 2017, 4:47 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56028/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2017, 4:47 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joris Van Remoortere, Joseph Wu, Michael Park,
and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7021
>     https://issues.apache.org/jira/browse/MESOS-7021
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Consistently add the FollowSymlink stat argument on Windows.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/windows/stat.hpp e7f471b828d96bb5cd01823dd78c8570730712ea

> 
> 
> Diff: https://reviews.apache.org/r/56028/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Fedora 25)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message