-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56027/#review168311
-----------------------------------------------------------
3rdparty/stout/include/stout/os/posix/stat.hpp
Line 30 (original), 30 (patched)
<https://reviews.apache.org/r/56027/#comment240527>
Do we want to return a `Try<::stat>` here, maybe? This way we can also factor out
the
```cpp
"Error invoking stat for '" + path + "'"
```
message here.
3rdparty/stout/include/stout/os/posix/stat.hpp
Line 30 (original), 30-43 (patched)
<https://reviews.apache.org/r/56027/#comment240530>
Let's put this in an `internal` namespace, and call `internal::stat` so that it's clear
from call-sites that we're not calling `::stat`
3rdparty/stout/include/stout/os/posix/stat.hpp
Lines 46-48 (patched)
<https://reviews.apache.org/r/56027/#comment240529>
Can we move this comment to just above:
```cpp
if (stat(path, DO_NOT_FOLLOW_SYMLINK, s) < 0) {
```
3rdparty/stout/include/stout/os/posix/stat.hpp
Lines 49-50 (patched)
<https://reviews.apache.org/r/56027/#comment240528>
Fits in one line.
3rdparty/stout/include/stout/os/stat.hpp
Lines 20-21 (patched)
<https://reviews.apache.org/r/56027/#comment240525>
The comment about "the default is always to follow" seems inaccurate from this perspective,
since it can't be enforced here. Is it meant as a guideline?
3rdparty/stout/include/stout/os/stat.hpp
Lines 21-22 (patched)
<https://reviews.apache.org/r/56027/#comment240526>
What does "only applies to the last path component" mean?
- Michael Park
On Feb. 1, 2017, 4:46 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56027/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2017, 4:46 p.m.)
>
>
> Review request for mesos, Alex Clemmer, Joris Van Remoortere, Joseph Wu, Michael Park,
and Jiang Yan Xu.
>
>
> Bugs: MESOS-7021
> https://issues.apache.org/jira/browse/MESOS-7021
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Consistently add the FollowSymlink stat argument on POSIX.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/stat.hpp e7440a4dab82ca3758a60a8fdc859476b2ee5693
> 3rdparty/stout/include/stout/os/stat.hpp 5c4fd4e630459059fa94c9f98e0d9b73d1280918
>
>
> Diff: https://reviews.apache.org/r/56027/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 25)
>
>
> Thanks,
>
> James Peach
>
>
|