mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 53264: Added test for CNI port-mapper plugin.
Date Wed, 08 Mar 2017 16:57:04 GMT


> On Feb. 28, 2017, 4:42 a.m., Jie Yu wrote:
> > src/tests/containerizer/cni_isolator_tests.cpp
> > Lines 1093-1097 (patched)
> > <https://reviews.apache.org/r/53264/diff/3/?file=1650779#file1650779line1093>
> >
> >     Instead of that, can we use `__MESOS_TEST__2`?

Hi Jie, 
Sorry for the delay here. We will need to change the `network/cni` isolator for this right?
Didn't really see a reason for this since replacing the existing CNI config would just work
the same. Will keep the logic in the `network/cni` isolator simpler?


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53264/#review166956
-----------------------------------------------------------


On Feb. 27, 2017, 10:13 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53264/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2017, 10:13 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-6022
>     https://issues.apache.org/jira/browse/MESOS-6022
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test for CNI port-mapper plugin.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cni_isolator_tests.cpp cb893d3ef005a9cc60c40768fa669b27c4863020

> 
> 
> Diff: https://reviews.apache.org/r/53264/diff/3/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message