mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 57385: Introduced proto changes needed for the DeleteNestedContainer API call.
Date Wed, 08 Mar 2017 01:04:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57385/#review168225
-----------------------------------------------------------


Fix it, then Ship it!





include/mesos/agent/agent.proto
Lines 186 (patched)
<https://reviews.apache.org/r/57385/#comment240433>

    Can you move this up to sit underneath the `KillNestedContainer` field. It's OK that the
proto numbers are out of order.



include/mesos/v1/agent/agent.proto
Lines 186 (patched)
<https://reviews.apache.org/r/57385/#comment240434>

    ditto


- Kevin Klues


On March 7, 2017, 5:13 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57385/
> -----------------------------------------------------------
> 
> (Updated March 7, 2017, 5:13 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-7120
>     https://issues.apache.org/jira/browse/MESOS-7120
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This new Agent API call will make it possible to destroy the sandbox and
> runtime directories of a terminated nested container.
> 
> 
> Diffs
> -----
> 
>   include/mesos/agent/agent.proto 9149724159485ea2265e1494c1ce7ef989dad20a 
>   include/mesos/v1/agent/agent.proto 34210c30ca58f50b14ff3e5a01c54003c9705121 
> 
> 
> Diff: https://reviews.apache.org/r/57385/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message