mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 57058: Updated default executor tests to exclusively use v1 protos.
Date Tue, 07 Mar 2017 23:40:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57058/#review168215
-----------------------------------------------------------


Ship it!





src/tests/default_executor_tests.cpp
Lines 215-217 (original), 215-217 (patched)
<https://reviews.apache.org/r/57058/#comment240412>

    Seems like these are the `devolve`s that we cannot avoid. :(


- Gilbert Song


On March 6, 2017, 5:15 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57058/
> -----------------------------------------------------------
> 
> (Updated March 6, 2017, 5:15 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Now all the tests in this file use v1 protos.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp e4d43c8ad447577a9c5c7951207596bda1070856 
> 
> 
> Diff: https://reviews.apache.org/r/57058/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message