mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 56733: Mount all supported subsystems in the containerizer tests.
Date Tue, 07 Mar 2017 19:28:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56733/#review168173
-----------------------------------------------------------



So I was thinking about this: the code here makes sure the OS has the minimum set of subsystems
required by this test suite. If the system doesn't meet the requirement, we do want to terminate
here. On the other hand, although mounting more subsystems isn't harmful, if we mount everything
that comes out of `cgroups::subsystems()`, we should still check whether that list is a superset
of the minimumally required set. At a result we still have to add items here every time a
new subsystem is added so we are not saving much?

Thoughts?

- Jiang Yan Xu


On March 6, 2017, 11:34 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56733/
> -----------------------------------------------------------
> 
> (Updated March 6, 2017, 11:34 a.m.)
> 
> 
> Review request for mesos, Mesos Reviewbot and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7049
>     https://issues.apache.org/jira/browse/MESOS-7049
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Rather than a hard-coded list of subsystems, just mount everything we
> find that is supported.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.cpp 6a96fa51dfc2a62063c3154b256bdac707b009bb 
> 
> 
> Diff: https://reviews.apache.org/r/56733/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check (Fedora 25)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message