mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 55790: Support the full CNI DNS specification.
Date Tue, 07 Mar 2017 17:01:16 GMT


> On March 7, 2017, 2:22 p.m., Avinash sridharan wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp
> > Lines 999 (patched)
> > <https://reviews.apache.org/r/55790/diff/4/?file=1652771#file1652771line1008>
> >
> >     Do you explicitly need this? Even if you do please define this at the top.

AFAICT this is required here. I wasn't able to find a different permutation that would build.


> On March 7, 2017, 2:22 p.m., Avinash sridharan wrote:
> > src/tests/containerizer/cni_isolator_tests.cpp
> > Lines 1112 (patched)
> > <https://reviews.apache.org/r/55790/diff/4/?file=1652774#file1652774line1134>
> >
> >     Instead of setting this to the hosts IP address can we set it to the `loopback`
(127.0.0.1). We want the query to this nameserver to fail before it hits the google servers.

> >     
> >     Just being a bit cautious here in case there is a DNS masquerade running on
the host :).

dnsmasq would listen on loopback too, but sure :)


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55790/#review168128
-----------------------------------------------------------


On March 1, 2017, 4:51 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55790/
> -----------------------------------------------------------
> 
> (Updated March 1, 2017, 4:51 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Jie Yu, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6858
>     https://issues.apache.org/jira/browse/MESOS-6858
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add support for the full set of DNS resolver configuration items that
> a CNI IPAM plugin can specify. This implements updating the container's
> resolv.conf with the 'domain', 'search', and 'options' keywords.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 84dc157e7d9e332a6da0f1fc33303e9ef9bdc147

>   src/slave/containerizer/mesos/isolators/network/cni/spec.hpp ccd511ec14810dcc1020dec5e1641141f3a319b4

>   src/slave/containerizer/mesos/isolators/network/cni/spec.cpp ac48159dadcea422f605e723db94a7f3bb573fa2

>   src/tests/containerizer/cni_isolator_tests.cpp cb893d3ef005a9cc60c40768fa669b27c4863020

> 
> 
> Diff: https://reviews.apache.org/r/55790/diff/4/
> 
> 
> Testing
> -------
> 
> sudo make check (Fedora 25)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message