mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 57166: Updated role validation for hierarchical roles.
Date Tue, 07 Mar 2017 15:37:06 GMT


> On March 7, 2017, 5:26 a.m., Michael Park wrote:
> > src/common/roles.cpp
> > Lines 72 (patched)
> > <https://reviews.apache.org/r/57166/diff/2/?file=1653834#file1653834line73>
> >
> >     For these error messages, how about we say something like this?
> >     
> >     ```cpp
> >     "A role cannot start with a slash, given: '" + role + "'"
> >     ```
> >     
> >     Here and below.

The "given" phrasing here seems confusing to me (it isn't clear who is being "given" what...).
Personally I think the current phrasing is okay...


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57166/#review168096
-----------------------------------------------------------


On March 2, 2017, 6:12 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57166/
> -----------------------------------------------------------
> 
> (Updated March 2, 2017, 6:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Role names can now contain forward slashes. Each component in a role
> name must now be validated separately.
> 
> 
> Diffs
> -----
> 
>   src/common/roles.cpp 31774a9b8f99f5efeed35b1c3e3486e05ca00f6a 
>   src/tests/role_tests.cpp 77f3d46a544a51ba71476e2f0735bb32758dd9e1 
> 
> 
> Diff: https://reviews.apache.org/r/57166/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message