mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 56757: Added the SecretGenerator module interface.
Date Tue, 07 Mar 2017 07:13:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56757/#review168099
-----------------------------------------------------------




include/mesos/authentication/secret_generator.hpp
Lines 29-32 (patched)
<https://reviews.apache.org/r/56757/#comment240224>

    Could you elaborate a bit here? The secret is meant to contain a token (for example, an
Authorization header) that can be used to authenticate, such that an authenticator will return
the principal that was passed to the `generate` method of this module.


- Greg Mann


On Feb. 28, 2017, 1:37 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56757/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2017, 1:37 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Greg Mann.
> 
> 
> Bugs: MESOS-6997
>     https://issues.apache.org/jira/browse/MESOS-6997
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This interface will be used by agents to create credentials for the
> default executor.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authentication/secret_generator.hpp PRE-CREATION 
>   include/mesos/module/secret_generator.hpp PRE-CREATION 
>   src/Makefile.am 76d58a0bbd77fe59ff8a81ba7a68c84dc7169750 
> 
> 
> Diff: https://reviews.apache.org/r/56757/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message